feat(#2915): callout v2 layout and emphasis levels #3100
Conversation
bdfranck
force-pushed
the
benjifranck/v2-callout-update
branch
from
9c3ec2c to
caf6669
Compare
There was a problem hiding this comment.
Looks great @bdfranck , just a couple adjustments suggested below.
Also, it looks like the heading font-weight is showing up as bold, not semi-bold. Now that I look at it, I think it's the same for the Modal heading where it uses semi-bold. It is showing font-weight 600, but visually looks off. Maybe we can connect to figure this one out.
Coded component (left), Figma component (right):
|
@twjeffery I've amended the commit to address all your comments. I'm not sure why semi-bold isn't displaying properly. I triple checked that the value is 
|
bdfranck
force-pushed
the
benjifranck/v2-callout-update
branch
from
dbeba95 to
fa22e3f
Compare
Ok, no worries. I noticed it's the same for any semi-bold throughout our components. (modal, drawer, and more). We will fix this across the system when we figure it out. |
bdfranck
changed the base branch from
v2-2998-coded-component-updates
to
dev
bdfranck
force-pushed
the
benjifranck/v2-callout-update
branch
from
fa22e3f to
cb0b5d9
Compare
|
@chrisolsen I've reset and rebased this branch from latest |
twjeffery
left a comment
twjeffery
left a comment
There was a problem hiding this comment.
The changes look the same as before you rebased
|
🎉 This PR is included in version 1.40.0-dev.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.10.0-dev.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.10.0-dev.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.10.0-dev.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR updates the callout to matches the new v2 Callout component. It makes the following changes: